Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6073] Fix bugs on spatial docs upload. #3227

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Conversation

henryoforeh-dev
Copy link
Contributor

Objective

MDS-6073

Why are you making this change? Provide a short explanation and/or screenshots

Fixed a bug due to an oversight in my last PR. List of bugs fixed:

  • Data was not saved in the mine_document_bundle table.
  • Uploaded spatial bundle files are not displaying as expected.
  • The hyperlink to the spatial standards URL is not functioning.

@@ -35,6 +35,8 @@ class MajorMineApplicationDocumentXref(Base):
create_user = association_proxy('mine_document', 'create_user')
versions = association_proxy('mine_document', 'versions')
update_timestamp = association_proxy('mine_document', 'update_timestamp')
mine_document_bundle = association_proxy('mine_document', 'mine_document_bundle')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would want to avoid including the whole bundle with the document like in project_summary_document_xref.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from project_summary_document_xref.
image

Copy link
Collaborator

@taraepp taraepp Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no! I thought we took that out! Are we using it on the FE anywhere? If not, it's doing a much larger query than necessary, especially if it queries it every time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see mine_document_bundle_id as well. I know that is used in the FE. I will remove the other one from my code to see if it breaks anything.

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
41.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
42.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@henryoforeh-dev henryoforeh-dev merged commit be1d7c0 into develop Aug 23, 2024
13 of 14 checks passed
@henryoforeh-dev henryoforeh-dev deleted the MDS-6073-bug-fix branch August 23, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants