-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-6073] Fix bugs on spatial docs upload. #3227
Conversation
@@ -35,6 +35,8 @@ class MajorMineApplicationDocumentXref(Base): | |||
create_user = association_proxy('mine_document', 'create_user') | |||
versions = association_proxy('mine_document', 'versions') | |||
update_timestamp = association_proxy('mine_document', 'update_timestamp') | |||
mine_document_bundle = association_proxy('mine_document', 'mine_document_bundle') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would want to avoid including the whole bundle with the document like in project_summary_document_xref
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no! I thought we took that out! Are we using it on the FE anywhere? If not, it's doing a much larger query than necessary, especially if it queries it every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see mine_document_bundle_id as well. I know that is used in the FE. I will remove the other one from my code to see if it breaks anything.
Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'Failed conditions |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'Issues Measures |
Objective
MDS-6073
Why are you making this change? Provide a short explanation and/or screenshots
Fixed a bug due to an oversight in my last PR. List of bugs fixed: